Skip to content
This repository was archived by the owner on Dec 2, 2019. It is now read-only.

Implement timestamp option for ios#21

Open
n1ru4l wants to merge 4 commits intophuochau:masterfrom
n1ru4l:feature-ios-thumbnail-timestamp
Open

Implement timestamp option for ios#21
n1ru4l wants to merge 4 commits intophuochau:masterfrom
n1ru4l:feature-ios-thumbnail-timestamp

Conversation

@n1ru4l
Copy link
Contributor

@n1ru4l n1ru4l commented Apr 12, 2018 •
edited
Loading

Implements #18

Code sample:

import RNThumbnail from 'react-native-thumbnail';
const timestampInSeconds = 3
RNThumbnail.get(filepath, { timestamp: timestampInSeconds }).then((result) => {
  console.log(result.path); // thumbnail path
})

@n1ru4l n1ru4l force-pushed the feature-ios-thumbnail-timestamp branch from 7e6358c to 961bf0f Compare April 12, 2018 12:54
@n1ru4l n1ru4l force-pushed the feature-ios-thumbnail-timestamp branch from 961bf0f to d3585a8 Compare April 13, 2018 07:44
@n1ru4l n1ru4l mentioned this pull request May 8, 2018
Open
@phuochau
Copy link
Owner

phuochau commented Oct 14, 2018

@n1ru4l I think the code example is wrong? The timestamp should be an option of get function

@n1ru4l
Copy link
Contributor Author

n1ru4l commented Oct 15, 2018

@phuochau I updated the example, however the code is fully functional

@watadarkstar
Copy link

watadarkstar commented Oct 18, 2018

@n1ru4l What would happen if that frame / timestamp doesn't exist?

@n1ru4l
Copy link
Contributor Author

n1ru4l commented Feb 18, 2019

@watadarkstar You will receive the last frame if the timestamp exceeds the maximum duration of the video.

@phuochau Is there anything further you need to be added before merging this?

Offtopic:

@phuochau Have you considered moving this repository over to react-native-community or adding additional maintainers? This could improve the quality and development of this library significantly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

need improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@n1ru4l @phuochau @watadarkstar